You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm run dev (and associated npm run start) used to start on port 3000, which was the old vite default. The default changed to 5173, but no reason we can't keep the previous behavior #6018 (review)
Test plan
Before
npm run dev listens on port 5173 (after #6018 was merged)
After
npm run dev listens on port 3000
tests and other commands that also specify a port still get the desired choice
Does it make sense to put the port in the vite config file, rather than extend the npm scripts. I think it's cleaner, no strong opinion on this. Approved.
@ivailop7 I also don't have a strong opinion about it either way. server: {port: 3000} in the vite.config.ts does that. If you specify multiple ports on the command line it takes the last one, so practically speaking other than where the setting is it's not a very observable difference. We manually specify the port elsewhere in the package.json files so I just did it in the same place.
@ivailop7 I also don't have a strong opinion about it either way. server: {port: 3000} in the vite.config.ts does that. If you specify multiple ports on the command line it takes the last one, so practically speaking other than where the setting is it's not a very observable difference. We manually specify the port elsewhere in the package.json files so I just did it in the same place.
CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
etrepum
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
facebook-github-bot
added
the
CLA Signed
Description
npm run dev(and associatednpm run start) used to start on port 3000, which was the old vite default. The default changed to 5173, but no reason we can't keep the previous behavior #6018 (review)Test plan
Before
npm run devlistens on port 5173 (after #6018 was merged)After
npm run devlistens on port 3000